CRE-1325 #1713
Open
CRE-1325 #1713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 mchain0, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
mchain0
had a problem deploying
to
integration
GitHub Actions
Failure
mchain0
had a problem deploying
to
integration
GitHub Actions
Failure
✅ API Diff Results - No breaking changes |
mchain0
had a problem deploying
to
integration
GitHub Actions
Failure
mchain0
had a problem deploying
to
integration
GitHub Actions
Failure
| Err: fmt.Errorf("requested seqNum %d for executionID %s is greater than the number of observed don times %d", | ||
| req.SeqNum, req.WorkflowExecutionID, numObservedDonTimes), | ||
| }) | ||
| cancel() |
Contributor
There was a problem hiding this comment.
what do you want to achieve with this cancel? The SendRepsonse is a sync function that either succeeds or fails. Calling cancel() afterwards does not seem to do anything.
jmank88
reviewed
Nov 18, 2025
| return nil, nil | ||
| } | ||
|
|
||
| func (p *Plugin) Observation(_ context.Context, outctx ocr3types.OutcomeContext, query types.Query) (types.Observation, error) { |
Contributor
There was a problem hiding this comment.
Shouldn't this parent context be used?
Suggested change
| func (p *Plugin) Observation(ctx context.Context, outctx ocr3types.OutcomeContext, query types.Query) (types.Observation, error) { |
jmank88
reviewed
Nov 18, 2025
Comment on lines
+33
to
+39
| // Don't block if receiver not ready, but check if context is actually expired | ||
| select { | ||
| case <-ctx.Done(): | ||
| // Context cancelled or deadline exceeded before send | ||
| default: | ||
| // Try once more without blocking | ||
| } |
Contributor
There was a problem hiding this comment.
You can just check for an error instead of using the channel mechanism:
Suggested change
| // Don't block if receiver not ready, but check if context is actually expired | |
| select { | |
| case <-ctx.Done(): | |
| // Context cancelled or deadline exceeded before send | |
| default: | |
| // Try once more without blocking | |
| } | |
| // Don't block if receiver not ready, but check if context is actually expired | |
| ctx.Err() |
But what is meant to happen here? Both cases are no-ops.
jmank88
reviewed
Nov 18, 2025
Comment on lines
+92
to
+101
| ctx, cancel := context.WithDeadline(context.Background(), req.ExpiryTime()) | ||
| req.SendResponse(ctx, | ||
| Response{ | ||
| WorkflowExecutionID: req.WorkflowExecutionID, | ||
| SeqNum: req.SeqNum, | ||
| Timestamp: 0, | ||
| Err: fmt.Errorf("requested seqNum %d for executionID %s is greater than the number of observed don times %d", | ||
| req.SeqNum, req.WorkflowExecutionID, numObservedDonTimes), | ||
| }) | ||
| cancel() |
Contributor
There was a problem hiding this comment.
re: @pavel-raykov - you can use anonymous closures to reduce scope of deferred actions:
Suggested change
| ctx, cancel := context.WithDeadline(context.Background(), req.ExpiryTime()) | |
| req.SendResponse(ctx, | |
| Response{ | |
| WorkflowExecutionID: req.WorkflowExecutionID, | |
| SeqNum: req.SeqNum, | |
| Timestamp: 0, | |
| Err: fmt.Errorf("requested seqNum %d for executionID %s is greater than the number of observed don times %d", | |
| req.SeqNum, req.WorkflowExecutionID, numObservedDonTimes), | |
| }) | |
| cancel() | |
| func() { | |
| ctx, cancel := context.WithDeadline(context.Background(), req.ExpiryTime()) | |
| defer cancel() | |
| req.SendResponse(ctx, | |
| Response{ | |
| WorkflowExecutionID: req.WorkflowExecutionID, | |
| SeqNum: req.SeqNum, | |
| Timestamp: 0, | |
| Err: fmt.Errorf("requested seqNum %d for executionID %s is greater than the number of observed don times %d", | |
| req.SeqNum, req.WorkflowExecutionID, numObservedDonTimes), | |
| }) | |
| } () |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRE-1325
Adds deadline-aware timeout handling for channel operations, preventing indefinite blocking and silent message drops when requests expire.